Remove empty result_set_to_ruby_data_type method#297
Merged
yahonda merged 1 commit intoMay 13, 2026
Conversation
The method was defined as an empty stub in JDBCConnection (`def ... end` with no body, returning nil). It had zero call sites anywhere in lib/ or spec/, no dynamic dispatch construction targets the name, and the enclosing class is tagged `# :nodoc:` so it is not part of a documented public API. Drop the dead code. Net change: -3 LOC. No behavior change. Full suite is green (468 examples, 0 failures, 1 pre-existing pending). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JDBCConnectiondefined an empty stub:It returned
nil, had zero call sites anywhere inlib/orspec/, and no dynamic dispatch construction targets the name. The enclosing class is tagged# :nodoc:, so removing the stub does not affect a documented public API surface.Verification before deletion
grep -rn "result_set_to_ruby_data_type" lib/ spec/→ 1 match (the definition itself)grep -rn "send.*result_set|to_ruby_data_type|public_send.*result|respond_to?.*result_set" lib/ spec/→ no dynamic-dispatch construction would resolve to this nameplsql.<procedure>style APIs, not this internal methodclass JDBCConnection < Connection # :nodoc:— opted out of public documentationOrigin
git log --all -S "def result_set_to_ruby_data_type" -- lib/plsql/jdbc_connection.rbshows the method was introduced empty from day one in commitca4bebf(2009-11-17), part of the larger "support for cursor return values and output parameters in JRuby / JDBC" change that overhauledjdbc_connection.rb(+154 / -113 across 4 files).The signature
(column_type, column_type_name)mirrors JDBC'sResultSetMetaData#getColumnType(i)/#getColumnTypeName(i), suggesting it was planned as a JDBC-ResultSet counterpart toplsql_to_ruby_data_type(metadata)— but the implementation that actually landed took a different route (theSQL_TYPE_TO_RUBY_CLASSlookup used byget_ruby_value_from_result_set). The stub was orphaned and never called. Across ~16 years and 5 subsequent edits to the method's textual surface, every change has been whitespace-only.Diff stat:
lib/plsql/jdbc_connection.rb | 3 ---(-3 lines).Test plan
bundle exec rspec— 468 examples, 0 failures, 1 pre-existing pendingruby -c lib/plsql/jdbc_connection.rbpasses🤖 Generated with Claude Code